Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish button styling issue #15029

Closed
HardeepAsrani opened this issue Apr 17, 2019 · 2 comments · Fixed by #16303
Closed

Publish button styling issue #15029

HardeepAsrani opened this issue Apr 17, 2019 · 2 comments · Fixed by #16303
Assignees
@sarahmonster
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Milestone
WordPress 5.2.x

Comments

@HardeepAsrani
Copy link
Contributor

Describe the bug
When you click on Publish button, it looks like this while it's in isBusy state. It appears is-default class is being added to the button even when it's set to primary.

Screen Shot 2019-04-18 at 3 16 42 AM

To reproduce
Steps to reproduce the behavior:

  1. Open Gutenberg and click on Publish.
  2. Or you can manually add is-busy class to the button.

Expected behavior
Color to be blue.

Desktop (please complete the following information):

  • OS:MacOS
  • Browser Firefox latest
@youknowriad youknowriad mentioned this issue Apr 18, 2019
Merged
5 tasks
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Apr 18, 2019
@sarahmonster sarahmonster self-assigned this Apr 25, 2019
@sarahmonster sarahmonster mentioned this issue May 17, 2019
Closed
@jemlovestodraw
Copy link

Feedback as per #15231
Agreed, it is hard to read. A simple fix could be to put the text (Updating...) in the medium blue of the original button.

@ocean90 ocean90 added this to the WordPress 5.2.x milestone Jun 5, 2019
@aduth aduth mentioned this issue Jun 7, 2019
Merged
@aduth aduth mentioned this issue Jun 26, 2019
Merged
@aduth
Copy link
Member

aduth commented Jun 26, 2019

Fix at #16303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahmonster sarahmonster

Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
WordPress 5.2.x
Development

Successfully merging a pull request may close this issue.

Editor: Resolve Publish button busy state styling regression WordPress/gutenberg
6 participants
@youknowriad @sarahmonster @ocean90 @aduth @HardeepAsrani @jemlovestodraw