Fixes plural messages POT generation.

[zinigor]

Description

In order for POT files to be generated with proper plural string templates, the nplurals variable had to be cast to int.

How has this been tested?

To test you will need to have a test file that uses plural i18n functions:

/**
 * External dependencies
 */
import { _n, _nx } from '@wordpress/i18n';

_n( 'Singular string', 'Plural string', 'textdomain' );
_nx( 'Singular string', 'Plural string', 'context', 'textdomain' );

Also you need to be using the makepot plugin in your project when processing files with Babel:

 [
		'@wordpress/babel-plugin-makepot',
		{
			output: 'gettext.pot'
			headers: {
				'content-type': 'text/plain; charset=UTF-8',
				'plural-forms': 'nplurals=2; plural=n == 1 ? 0 : 1;',
			},
		},
	]

After you have set up your repository, run babel against this file:

$ npx babel test.js 
"use strict";

var _i18n = require("@wordpress/i18n");

/**
 * External dependencies
 */
(0, _i18n._n)('Singular string', 'Plural string', 'textdomain');
(0, _i18n._nx)('Singular string', 'Plural string', 'context', 'textdomain');

You will have an gettext.pot file generated in the folder where you ran the script from, it will have the following lines:

msgid ""
msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"X-Generator: calypso\n"
"Plural-Forms: nplurals=2; plural=n == 1 ? 0 : 1;\n"

#: test.js:8
msgid "Singular string"
msgid_plural "Plural string"
msgstr[0] ""

#: test.js:9
msgctxt "textdomain"
msgid "Singular string"
msgid_plural "Plural string"
msgstr[0] ""

Notice how the msgstr entry is only one per message, and there should be two of them, based on the nplurals setting in the header. Roll this patch on, see the different result:

msgid ""
msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"X-Generator: calypso\n"
"Plural-Forms: nplurals=2; plural=n == 1 ? 0 : 1;\n"

#: test.js:8
msgid "Singular string"
msgid_plural "Plural string"
msgstr[0] ""
msgstr[1] ""

#: test.js:9
msgctxt "textdomain"
msgid "Singular string"
msgid_plural "Plural string"
msgstr[0] ""
msgstr[1] ""

Types of changes

• Minor change to the babel-plugin-makepot package: bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[aduth]

Could you please add an entry to packages/babel-plugin-makepot/CHANGELOG.md describing the bug fix?

See also: https://github.com/WordPress/gutenberg/blob/master/packages/README.md#maintaining-changelogs

[zinigor]

Thanks for the review, Andrew! I have moved parseInt, as well as added a CHANGELOG entry.

[aduth]

Looks great, thanks! 👍