Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_get_script_polyfill #13536

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 28, 2019

Related: #11015

This pull request seeks to deprecate Gutenberg's gutenberg_get_script_polyfill in favor of the equivalent core function wp_get_script_polyfill.

Testing Instructions:

Verify there are no warning notices from the deprecation of gutenberg_get_script_polyfill, and that by viewing source while on the Gutenberg editor, the || document.write( script polyfills are still present in markup.

@aduth aduth added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jan 28, 2019
@aduth aduth force-pushed the deprecate/script-polyfill branch from ac6f065 to e1e9461 Compare January 28, 2019 14:27
@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 29, 2019
@aduth aduth force-pushed the deprecate/script-polyfill branch from e1e9461 to d773e75 Compare January 29, 2019 16:39
@aduth aduth merged commit 797df63 into master Jan 29, 2019
@aduth aduth deleted the deprecate/script-polyfill branch January 29, 2019 17:05
daniloercoli added a commit that referenced this pull request Jan 30, 2019
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (36 commits)
  Fixes plural messages POT generation. (#13577)
  Typo fix (#13595)
  REST API: Remove oEmbed proxy HTML filtering (#13575)
  Removed unnecessary className attribute. Fixes #11664 (#11831)
  Add changelog for RSS block (#13588)
  Components: Set type=button for TabPanel button elements. (#11944)
  Update util.js (#13582)
  Docs: Add accessbility specific page (#13169)
  Rnmobile/media methods refactor (#13554)
  chore(release): publish
  chore(release): publish
  Plugin: Deprecate gutenberg_get_script_polyfill (#13536)
  Block API: Parse entity only when valid character reference (#13512)
  RichText: List: fix indentation (#13563)
  Plugin: Deprecate window._wpLoadGutenbergEditor (#13547)
  Plugin: Avoid setting generic "Edit Post" title on load (#13552)
  Plugin: Populate demo content by default content filters (#13553)
  RichText: List: Fix getParentIndex (#13562)
  RichText: List: Fix outdent with children (#13559)
  Scripts: Remove npm run build from test-e2e default run (#13420)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants