Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_kses_allowedtags #13460

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 24, 2019

Related: #11015
Related: #9875

This pull request seeks to deprecate and remove logic from gutenberg_kses_allowedtags. data- attributes are now whitelisted in core as of v5.0, and thus it is no longer necessary.

See:

Testing instructions:

Repeat testing instructions from #9875 .

@aduth aduth added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jan 24, 2019
@aduth aduth requested a review from notnownikki January 24, 2019 00:20
@aduth aduth added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Jan 24, 2019
Copy link
Member

@notnownikki notnownikki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested publishing and editing a gallery with an author level user and there were no issues. 🚢

@aduth aduth force-pushed the deprecate/gutenberg_kses_allowedtags branch from 165a967 to 405706f Compare January 24, 2019 14:45
@aduth aduth merged commit 4d8fd5d into master Jan 24, 2019
@aduth aduth deleted the deprecate/gutenberg_kses_allowedtags branch January 24, 2019 15:02
daniloercoli added a commit that referenced this pull request Jan 24, 2019
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants