Plugin: Remove 5.0-merged block registration functions, integrations #13412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Block API
5 tasks
youknowriad
reviewed
Jan 22, 2019
lib/blocks.php
Outdated
| * | ||
| * @param string $content Content of the current post. | ||
| * @return string | ||
| */ | ||
| function strip_dynamic_blocks( $content ) { | ||
| _deprecated_function( __FUNCTION__, '4.9.0' ); |
There was a problem hiding this comment.
Is the intent here to remove these in 5.1?
There was a problem hiding this comment.
Is the intent here to remove these in 5.1?
That would be the idea, yes.
I can plan to add a note:
youknowriad
approved these changes
Jan 22, 2019
aduth
force-pushed
the
remove/blocks-registry-render-php
branch
from
ed99f33 to
4d185c2
Compare
daniloercoli
added a commit
that referenced
this pull request
Jan 24, 2019
…rnmobile/372-add-title-to-gutenberg-mobile * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Save package-lock.json file changes (#13481) Plugin: Deprecate gutenberg_add_responsive_body_class (#13461) Add speak messages to the feature toggle component. (#13385) Plugin: Deprecate gutenberg_kses_allowedtags (#13460) Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472) Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446) Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473) Fix: Categories block: add custom classes only to wrapper (#13439) is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428) Update and Organize Contributors Guide per #12916 (#13352) Dismissible-notices: fix text overlapping icon (X) (#13371) Framework: Remove 5.0-merged REST API integrations (#13408) Plugin: Remove 5.0-merged block registration functions, integrations (#13412) Framework: Bump minimum required WP to 5.x (#13370) [Mobile] Improve keyboard hide button (#13415) Improve castError handling of non strings (#13315) Fix: File block add custom class (#13432) Consider making Fullscreen Mode effects visible only on larger screens (#13425) Update plugin version to 4.9.0 (#13436) DateTimePicker: fix prop warning for (#12933) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11015
Blocked by: #13370
This pull request seeks to remove block registration classes and block integration PHP code which has been merged as part of the 5.0 release.
The classes will never have been loaded in a WordPress 5.0 environment, since they're conditionally loaded by the non-presence of the class.
The following functions are specific to Gutenberg, either by prefix or non-merge to 5.0. They have been marked as deprecated, and should be removed from the Gutenberg plugin.
gutenberg_parse_blocks(useparse_blocks()instead)get_dynamic_blocks_regex(not used)gutenberg_render_block(userender_block()instead)strip_dynamic_blocks(handled in core byexcerpt_remove_blocks†)strip_dynamic_blocks_add_filter(handled in core byexcerpt_remove_blocks†)strip_dynamic_blocks_remove_filter(handled in core byexcerpt_remove_blocks†)I'm uncertain about the use of
_deprecated_functionas it's intended for use in deprecating core functions, but there is precedent for it already.† The removed test case
test_excerpt_infinite_loopdoes not seem to have an equivalent in thewordpress-developrepository.