Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gallery block so it limits the columns to the the current number of images #13443

Conversation

brentswisher
Copy link
Contributor

Description

Update the columns attribute when the onSelectImages function fires so that if images are removed via the media modal, the columns will be updated. This way columns won't be higher than the new number of images.

Previously this worked if removing images via the X in the editor, but not if you removed them via the media modal

Fixes #13423

How has this been tested?

Add a gallery with multiple images, set the columns to be the maximum allowed. Edit the gallery via the media modal and remove images, when you save the media modal, the columns should be adjusted to match the new number of photos.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

brentswisher and others added 4 commits January 23, 2019 11:45
…removed via the media modal, the columns can't be higher than the new number of images
* Dismissible-notices: fix text overlapping icon (X)

* Dismissible-notices: fix text overlapping icon (X) - pt.2.
…#13352)

* Organize and reorder Contributors Guide per WordPress#12916

* Remove individual outreach pages, combined into single outreach.md

* Principles link, sections heading

* Fix link

* Fix link, typo

* Update docs/contributors/readme.md

Co-Authored-By: mkaz <[email protected]>

* Remove meetups, there are far too many to list, since most meetups now all cover Gutenberg in some degree or other

* Update CONTRIBUTING with links to Documentation section

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <[email protected]>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <[email protected]>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <[email protected]>

* Update docs/contributors/outreach.md

Co-Authored-By: mkaz <[email protected]>

* Update docs/contributors/outreach.md

Co-Authored-By: mkaz <[email protected]>

* Update docs/contributors/document.md

Co-Authored-By: mkaz <[email protected]>

* Update docs/contributors/document.md

Co-Authored-By: mkaz <[email protected]>

* Add some newlines, take some away

* Paragraph for resources

* Update title in generator

* Update docs/contributors/develop.md

Co-Authored-By: mkaz <[email protected]>
this.setAttributes( {
images: images.map( ( image ) => pickRelevantMediaFiles( image ) ),
columns: Math.min( images.length, columns ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use columns: columns ? Math.min( images.length, columns ) : columns, here like we do in onRemoveImage. This ensures that we will not set the columns attribute if it was not set before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, I updated this to make that change but in trying to rebase my two commits into one I royally messed something up and commits from other people are showing up here. Since it's such a simple code change, Instead of trying to fix this pull request (and likely making it worse), I'm just going to close this and open a different, sorry for the inconvenience @jorgefilipecosta

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Package] Block library /packages/block-library [Block] Gallery Affects the Gallery Block - used to display groups of images labels Jan 24, 2019
@jorgefilipecosta jorgefilipecosta added this to the 5.0 (Gutenberg) milestone Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery: removing images doesn't update maximum number of columns
8 participants