Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update section on transforming from shortcodes #12213

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 22, 2018

Description

Replacement for #11693 which I could rebase after docs structure changes.

Props to @jakeparis for catching the issue. This PR also adds @jakeparis to the list of contributors.

input into shortcode is missing destructuring syntax.

I opted for ES5 syntax to ensure it works also in older browsers like IE11.

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Nov 22, 2018
@gziolo gziolo added this to the 4.6 milestone Nov 22, 2018
@gziolo gziolo self-assigned this Nov 22, 2018
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ajitbohra ajitbohra merged commit f090e84 into master Nov 22, 2018
@gziolo gziolo deleted the update/api-docs-shortcode branch November 22, 2018 10:39
@youknowriad youknowriad modified the milestones: 4.6, 4.7 Nov 29, 2018
@mtias mtias modified the milestones: 4.7, Documentation & Handbook Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants