Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update section on transforming from shortcodes #12213

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Docs: Update section on transforming from shortcodes #12213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc29ab2
Docs: Update section on transforming from shortcodes
gziolo Nov 22, 2018
3b422eb
Add @jakeparis to the list of contributors
gziolo Nov 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,4 @@ This list is manually curated to include valuable contributions by volunteers th
| @getsource | @mikeschroder |
| @greatislander | @greatislander |
| @sharazghouri | @sharaz |
| @jakeparis | |
4 changes: 2 additions & 2 deletions docs/designers-developers/developers/block-api/block-registration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ transforms: {
// An attribute can be source from the shortcode attributes
align: {
type: 'string',
shortcode: function( named ) {
var align = named.align ? named.align : 'alignnone';
shortcode: function( attributes ) {
var align = attributes.named.align ? attributes.named.align : 'alignnone';
return align.replace( 'align', '' );
},
},
Expand Down