Split the comment #12193
Merged
Split the comment #12193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seperate the comment so translator comment is in it's own block.
Closed
swissspidy
reviewed
Nov 21, 2018
Updated the comments to address @swisspidy's review. Removed the redundant comment and switched to a single line comment block.
swissspidy
approved these changes
Nov 21, 2018
designsimply
added
the
Internationalization (i18n)
youknowriad
pushed a commit
that referenced
this pull request
Nov 29, 2018
* Split the comment Seperate the comment so translator comment is in it's own block. * Updated comments to address review Updated the comments to address @swisspidy's review. Removed the redundant comment and switched to a single line comment block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the comment so translator comment is in it's own block.
How has this been tested?
This is a change to comments so aside from loading to make sure nothing broke the test will be done as part of parsing.
Types of changes
Bug fix #12139 corrects the translator comments for i18n
Checklist: