RichText: fix format placeholder #11102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Rich Text
ellatrix
commented
Oct 26, 2018
packages/rich-text/src/to-tree.js
Outdated
| @@ -127,6 +140,18 @@ export function toTree( value, multilineTag, settings ) { | |||
| } | |||
| } | |||
|
|
|||
| if ( isEditableTree && formatPlaceholder && formatPlaceholder.index === i + 1 ) { | |||
There was a problem hiding this comment.
Logic needs to be unduplicated.
|
This doesn't appear to fix the issue for me:
|
ellatrix
force-pushed
the
try/rich-text-format-placeholder
branch
from
d4f397c to
0993a6b
Compare
|
@youknowriad I can't reproduce the bug. :/ |
|
Not sure what happened in my initial testing, this does fix the issue indeed. |
|
I can confirm that the original issue was fixed. I have two more issues to report. I will do it separately. |
gziolo
added
[Type] Bug
gziolo
approved these changes
Oct 30, 2018
daniloercoli
added a commit
that referenced
this pull request
Oct 31, 2018
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (21 commits) Fix property path on get() call (#10962) Fixed typos on block api documentation (#11298) Export `switchToBlockType` to be used mobile side when merging two blocks. (#11294) RichText: Remove unused `ref` assignment to RichText (#11222) Remove findDOMNode from Tooltip component (#11169) Components: Remove redundant onClickOutside handler from Dropdown (#11253) added myself to the contributors list (#11260) Add complete post type labels for Resuable Blocks (#11278) Increase specificity for active radio/checkbox input styling (#11290) Fixed "artifact" misspelling in docs. (#11291) Nux package: fix incorrect named deprecated import (#11283) Rename parentClientId to rootClientId for consistency (#11274) chore(release): update changelog files chore(release): publish Update plugin version to 4.2.0. (#11258) Data: Use turbo-combine-reducers in place of Redux (#11255) Revert using Icon in IconButton to avoid regression in plugin icons (pinned icons) (#11256) Block List: Use default Inserter for sibling insertion (#11018) Editor: Optimize Inserter props generation and reconciliation (#11243) RichText: fix format placeholder (#11102) ... # Conflicts: # packages/block-library/src/quote/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch fixes a few related issues:
The only solution for applying a format placeholder is to temporarily store an extra property on the value object that indicates to the editable tree creator that a format placeholder should appear there with the caret.
I added an e2e test to verify it works.
How has this been tested?
Ensure you can type while using formatting shortcuts (see e2e test). Ensure #10209 (comment) is not reproducible.
Screenshots
Types of changes
Bug fix.
Checklist: