Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase specificity for active radio/checkbox input styling #11290

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented Oct 31, 2018

Description

Extends selector to apply colors when input is :checked to override WordPress core styles.

Fixes #11261.

How has this been tested?

Deactivated Gutenberg and copied the new styles into /wp-includes/css/dist/edit-post/style.css.

Screenshots

Before:
before

After:
after

@ocean90 ocean90 requested a review from jasmussen October 31, 2018 09:02
@ocean90 ocean90 added the Needs Design Feedback Needs general design feedback. label Oct 31, 2018
@ocean90 ocean90 added this to the 4.3 milestone Oct 31, 2018
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it. Nice work.

@ocean90 ocean90 merged commit 529e3a2 into master Oct 31, 2018
@ocean90 ocean90 deleted the fix/input-checked-specificity branch October 31, 2018 10:49
daniloercoli added a commit that referenced this pull request Oct 31, 2018
…rnmobile/port-quote-block-step-1

* 'master' of https://github.com/WordPress/gutenberg: (21 commits)
  Fix property path on get() call (#10962)
  Fixed typos on block api documentation (#11298)
  Export `switchToBlockType` to be used mobile side when merging two blocks. (#11294)
  RichText: Remove unused `ref` assignment to RichText (#11222)
  Remove findDOMNode from Tooltip component (#11169)
  Components: Remove redundant onClickOutside handler from Dropdown (#11253)
  added myself to the contributors list (#11260)
  Add complete post type labels for Resuable Blocks (#11278)
  Increase specificity for active radio/checkbox input styling (#11290)
  Fixed "artifact" misspelling in docs. (#11291)
  Nux package: fix incorrect named deprecated import (#11283)
  Rename parentClientId to rootClientId for consistency (#11274)
  chore(release): update changelog files
  chore(release): publish
  Update plugin version to 4.2.0. (#11258)
  Data: Use turbo-combine-reducers in place of Redux (#11255)
  Revert using Icon in IconButton to avoid regression in plugin icons (pinned icons) (#11256)
  Block List: Use default Inserter for sibling insertion (#11018)
  Editor: Optimize Inserter props generation and reconciliation (#11243)
  RichText: fix format placeholder (#11102)
  ...

# Conflicts:
#	packages/block-library/src/quote/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants