Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all occurrences of 'new window' to 'new tab'. #10698

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Oct 17, 2018

Description

Quoting from the related issue #10697

Worth considering in core all occurrences of (opens in a new window) have been changed to (opens in a new tab), see https://core.trac.wordpress.org/ticket/43803 which will be released in 5.1 (note: not in 5.0).

In Gutenberg, the occurrences of new window are sometimes used for visually hidden accessible text and sometimes as visible labels. Regardless, for consistency and preparation with the change landing in core, I'd propose to change all occurrences to new tab.

Clarification, quoting from the Trac ticket:

today, it's very likely that browsers will open links with a target="_blank" attribute in a new browser's tab rather than in a new window. It is true that this depends also on user settings, but in the vast majority of the cases they will open in a new tab.

Fixes #10697

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 17, 2018
Copy link
Contributor

@Luciaisacomputer Luciaisacomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@afercia
Copy link
Contributor Author

afercia commented Oct 17, 2018

The build fails, one more case of test Demo content post › should be created with keyboard failing, see #10682 (comment) /Cc @aduth

@danielbachhuber danielbachhuber added this to the 4.1 - UI freeze milestone Oct 18, 2018
@danielbachhuber
Copy link
Member

Merged master to fix the failing build.

Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 👍

@tofumatt tofumatt merged commit c86502b into master Oct 18, 2018
@tofumatt tofumatt deleted the update/new-window-to-new-tab branch October 18, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants