Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all the occurrences of new window to new tab #10697

Closed
afercia opened this issue Oct 17, 2018 · 2 comments
Closed

Change all the occurrences of new window to new tab #10697

afercia opened this issue Oct 17, 2018 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Oct 17, 2018

Worth considering in core all occurrences of (opens in a new window) have been changed to (opens in a new tab), see https://core.trac.wordpress.org/ticket/43803 which will be released in 5.1 (note: not in 5.0).

In Gutenberg, the occurrences of new window are sometimes used for visually hidden accessible text and sometimes as visible labels. Regardless, for consistency and preparation with the change landing in core, I'd propose to change all occurrences to new tab.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 17, 2018
@afercia
Copy link
Contributor Author

afercia commented Oct 17, 2018

Also for clarification, quoting from the Trac ticket:

today, it's very likely that browsers will open links with a target="_blank" attribute in a new browser's tab rather than in a new window. It is true that this depends also on user settings, but in the vast majority of the cases they will open in a new tab.

@afercia
Copy link
Contributor Author

afercia commented Oct 17, 2018

Related: #9520 which is going to introduce a "new window" string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants