Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using addQueryArgs to generate Manage All Reusable Blocks link #10065

Closed
wants to merge 8 commits into from
Closed

Using addQueryArgs to generate Manage All Reusable Blocks link #10065

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d1ce90
feat: Use addQueryArgs to generate Manage All Reusable Blocks link
SofiaSousa Sep 20, 2018
ccdec53
feat: Use addQueryArgs to generate Manage All Reusable Blocks link (f…
SofiaSousa Sep 20, 2018
7a6f454
Merge branch 'upstream_master' into try/manage-reusable-blocks-link
SofiaSousa Jan 31, 2019
eb3c419
feat: Use addQueryArgs to generate Manage All Reusable Blocks link
SofiaSousa Jan 31, 2019
a11ff7a
fix: Import missing addQueryArgs method
SofiaSousa Jan 31, 2019
3abaa9b
Merge branch 'upstream_master' into try/manage-reusable-blocks-link
SofiaSousa Feb 1, 2019
33e9d85
Merge branch 'upstream_master' into try/manage-reusable-blocks-link
SofiaSousa Feb 2, 2019
517da1e
chore: Update package-lock after run [email protected] install
SofiaSousa Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 12 additions & 34 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/edit-post/src/plugins/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { MenuItem } from '@wordpress/components';
import { Fragment } from '@wordpress/element';
import { __ } from '@wordpress/i18n';
import { registerPlugin } from '@wordpress/plugins';
import { addQueryArgs } from '@wordpress/url';

/**
* Internal dependencies
Expand All @@ -22,7 +23,7 @@ registerPlugin( 'edit-post', {
<Fragment>
<MenuItem
role="menuitem"
href="edit.php?post_type=wp_block"
href={ addQueryArgs( 'edit.php', { post_type: 'wp_block' } ) }
>
{ __( 'Manage All Reusable Blocks' ) }
</MenuItem>
Expand Down
3 changes: 2 additions & 1 deletion packages/editor/src/components/inserter/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
import { withDispatch, withSelect } from '@wordpress/data';
import { withInstanceId, compose, withSafeTimeout } from '@wordpress/compose';
import { LEFT, RIGHT, UP, DOWN, BACKSPACE, ENTER } from '@wordpress/keycodes';
import { addQueryArgs } from '@wordpress/url';

/**
* Internal dependencies
Expand Down Expand Up @@ -323,7 +324,7 @@ export class InserterMenu extends Component {
<BlockTypesList items={ reusableItems } onSelect={ onSelect } onHover={ this.onHover } />
<a
className="editor-inserter__manage-reusable-blocks"
href="edit.php?post_type=wp_block"
href={ addQueryArgs( 'edit.php', { post_type: 'wp_block' } ) }
gziolo marked this conversation as resolved.
Show resolved Hide resolved
>
{ __( 'Manage All Reusable Blocks' ) }
</a>
Expand Down