Using addQueryArgs to generate Manage All Reusable Blocks link

[SofiaSousa]

Description

Using addQueryArgs method from @wordpress/url instead of hand coding 'Manage All Reusable Blocks' link.

How has this been tested?

1. Open 'Reusable' panel in 'Add Block' menu
2. Check 'Manage All Reusable Blocks' link is redirecting to edit.php?post_type=wp_block.
3. Open 'More' menu (top right ...)
4. Check 'Manage All Reusable Blocks' link is redirecting to edit.php?post_type=wp_block.

Screenshots

Types of changes

Reuse an existing method.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[youknowriad]

What's the benefit for using addQueryArgs if the URL is fixed?

[SofiaSousa]

To be coherent. Then in our case, we override addQueryArgs in order to apply the changes we need on the editor paths since paths are not configurable.

[gziolo]

I think it's fine to land it. @SofiaSousa can you refresh this PR with the latest changes from master?

In other places, I also see getWPAdminURL function uses. Did you consider using this one instead?

[SofiaSousa]

@gziolo PR has the latest changes from the master now.

I did a little search for getWPAdminURL and figured out that is just an "abstraction" of addQueryArgs. I don't know the reason for this, but probably there is a good one :)

Otherwise, I think we should replace all calls of getWPAdminURL.

[gziolo]

I did a little search for getWPAdminURL and figured out that is just an "abstraction" of addQueryArgs. I don't know the reason for this, but probably there is a good one :)

I'm confused as much as you are, good finding :)

@youknowriad a553056

• can we deprecate getWPAdminURL? I would prefer if we had a way to abstract away all links and make them filterable if plugins want to change those links or being easy to override if projects like G in Drupal prefers to do so.

I think addQueryArgs is fine for now in that case.

[gziolo]

Other than mentioned lock file changes, these changes look good. Thanks for refreshing.

[gziolo]

I see unrelated lock file changes in this PR. My bet is that it is because this file was regenerated using npm 6.7 which introduced some changes in a way optional flag is handled. Can you try to run npm install with the latest version of npm?

[SofiaSousa]

Which version did you mean? I had [email protected] when those "optional": true, appeared. Tried to update to the latest (npm install -g npm@latest) but the latest version is [email protected].

[gziolo]

the latest version is [email protected]

This one

[SofiaSousa]

My bad, I misunderstood your comment.

[gziolo]

I opened #13653 to fix the issue with the lock file. I tested those changes and they work as expected. Thank you for opening this PR. I will land your changes from my branch, but technically it will still get merged under your name :)