Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /assets folder to plugin build process #67835

Open
bph opened this issue Dec 11, 2024 · 4 comments
Open

add /assets folder to plugin build process #67835

bph opened this issue Dec 11, 2024 · 4 comments
Assignees
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@bph
Copy link
Contributor

bph commented Dec 11, 2024

What problem does this address?

It allows the implementation of a Playground blueprint for a Live preview of the Gutenberg plugin in the repo.
The blueprint was added in #67742

What is your proposed solution?

Add a line to the build process script. That's obviously wrong...

as @t-hamano was wondering about in this comment

@bph bph added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Dec 11, 2024
@sirreal
Copy link
Member

sirreal commented Dec 11, 2024

Assets are not part of the plugin zip, the assets would need to be synced to this directory on publish: https://plugins.trac.wordpress.org/browser/gutenberg/assets

@sirreal
Copy link
Member

sirreal commented Dec 11, 2024

It seems like assets should be synced as part of this flow.

@sirreal
Copy link
Member

sirreal commented Dec 11, 2024

The contents of https://plugins.trac.wordpress.org/browser/gutenberg/assets should probably also be synced to this repo if we go this route.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 11, 2024
@bph
Copy link
Contributor Author

bph commented Dec 11, 2024

So the folder /blueprints folder from this repo's /assets folder needs to go into the https://plugins.trac.wordpress.org/browser/gutenberg/assets folder.

Cc: @karmatosed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants