Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /assets folder to build-plugin-zip #67839

Closed
wants to merge 1 commit into from
Closed

Conversation

bph
Copy link
Contributor

@bph bph commented Dec 11, 2024

What?

Fixes #67835 and helps implementing a Playground preview for the Gutenberg plugin in the WordPress plugin repository, that was added in a previous PR #67742

Why?

The plugin repository needs the /assets/blueprints/folder in the plugin.zip

How?

added a line to the directories to be bundled.

Testing Instructions

Download the plugin.zip from the branch and see if the assets folder is included.

@bph bph added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Dec 11, 2024
@bph bph changed the title add assets to build-plugin-zip Add /assets folder to build-plugin-zip Dec 11, 2024
@bph bph requested review from gziolo and sirreal December 11, 2024 15:57
@WordPress WordPress deleted a comment from github-actions bot Dec 11, 2024
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the correct approach. The assets directory is not a part of the plugin, it does not need to be in the plugin zip.

I think the assets directory should probably be synced as part of the publish flow.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: bph <[email protected]>
Co-authored-by: sirreal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@bph
Copy link
Contributor Author

bph commented Dec 11, 2024

I close this pull request as it's not the right approach. Thanks for all the insights and setting me straight. @sirreal

@bph bph closed this Dec 11, 2024
@bph bph deleted the update/plugin-build branch December 11, 2024 16:34
@WordPress WordPress deleted a comment from github-actions bot Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add /assets folder to plugin build process
2 participants