-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Playground blueprint json to the /assets/blueprints folder of Plugin Repo #67742
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bph! This tests well for me. I approved the PR but left some notes about potential improvements, depending on what you think.
@sirreal @gziolo Do you know if the gutenberg/bin/build-plugin-zip.sh Lines 83 to 93 in b66f9ff
|
Oh, good catch @t-hamano - Thank you! |
I downloaded the plugin build artifact from this PR and the assets folder didn't come with it. |
I'm not sure how the plugin publish flow works for Gutenberg, but the asset directory is separate from what goes into the plugin zip on the plugin repository, so it's not surprising that it wouldn't be listed as part of the plugin zip. |
I added a new issue |
What?
Adds a blueprint.json to the assets/blueprints folder, to show a preview in the Plugins Directory for the plugin.
Fix #67739
Why?
To empower users to test and try out the latest Gutenberg plugin version.
How?
Following the Plugin Review Teams instructions.
Testing Instructions
Test via Playground (updated 12/11/24)