Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: "Rename" item is not displayed when no block is selected #55612

Closed
t-hamano opened this issue Oct 25, 2023 · 3 comments
Closed

List View: "Rename" item is not displayed when no block is selected #55612

t-hamano opened this issue Oct 25, 2023 · 3 comments
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

Description

In the List View, you can rename the block from the ellipsis menu. However, for some reason only the "Rename" item doesn't seem to display unless a block is selected.

This issue does not occur in WordPress 6.4 RC2, where only group blocks can be renamed. You should be able to reproduce it when you enable the latest Gutenberg trunk.

Step-by-step reproduction instructions

  • Insert some blocks.
  • Open the List View.
  • With no blocks selected, click the ellipsis button for one of the blocks.
  • There should be no "Rename" item.
  • Select that block.
  • There should be a "Rename" item.

Screenshots, screen recording, code snippet

b8dcc30e89eef5fbd2d6d53381f27cad.mp4

Environment info

  • WordPress Version: 6.4 RC2
  • Latest Gutenberg

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Oct 25, 2023
@t-hamano
Copy link
Contributor Author

I discovered that this issue was caused by #55250 to fix a performance regression. However, I personally find it unnatural that only the Rename menu is not displayed when no block is selected.

@getdave
Copy link
Contributor

getdave commented Oct 26, 2023

Noting that this Issue will be resolved once we complete the steps in #55604 (comment)

@t-hamano
Copy link
Contributor Author

The latest trunk does not reproduce this problem. I believe it's because #56386 was merged. Therefore, I would like to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants