Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Renaming Followups for 6.5 #55643

Closed
4 tasks done
getdave opened this issue Oct 26, 2023 · 7 comments · Fixed by #56386 or #56425
Closed
4 tasks done

Block Renaming Followups for 6.5 #55643

getdave opened this issue Oct 26, 2023 · 7 comments · Fixed by #56386 or #56425
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Oct 26, 2023

The following needs to be undertaken in the WP 6.5 cycle.

Originally posted by @getdave in #54426 (comment)

@getdave getdave self-assigned this Oct 26, 2023
@getdave getdave added [Feature] Blocks Overall functionality of blocks [Type] Code Quality Issues or PRs that relate to code quality [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Oct 26, 2023
@adamziel
Copy link
Contributor

adamziel commented Nov 15, 2023

@getdave Another one would be: If I have another block selected and I open the hamburger menu on the quote block, there’s no rename option

@getdave
Copy link
Contributor Author

getdave commented Nov 15, 2023

the hamburger menu on the quote block, there’s no rename option

Thanks for the report. Can you explain where this hamburger menu is? Screenshot of video capture much appreciated.

@adamziel
Copy link
Contributor

Rename option is there:

CleanShot 2023-11-15 at 16 23 04@2x

Rename option isn't there:

CleanShot 2023-11-15 at 16 22 57@2x

@t-hamano
Copy link
Contributor

Another one would be: If I have another block selected and I open the hamburger menu on the quote block, there’s no rename option

This seems to be the same issue reported in #55612.

@getdave
Copy link
Contributor Author

getdave commented Nov 17, 2023

Thanks @adamziel. We'll need to add a test for that. I'm going to try and dedicate some time to these followups next week (cc @scruffian ).

@getdave
Copy link
Contributor Author

getdave commented Nov 20, 2023

I'm circling back to these task this week having been otherwise engaged last week.

@getdave
Copy link
Contributor Author

getdave commented Nov 27, 2023

Reopening pending merge of #56155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
Status: Done
3 participants