Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer Widgets: Make editor top bar visible on scroll #30912

Open
critterverse opened this issue Apr 16, 2021 · 4 comments
Open

Customizer Widgets: Make editor top bar visible on scroll #30912

critterverse opened this issue Apr 16, 2021 · 4 comments
Assignees
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@critterverse
Copy link
Contributor

Hi all, re-sharing an idea that came up in #30720 (comment) around the scrolling behavior for the editor "top bar."

I'm wondering if the top bar should act as a sticky element on scroll — meaning the Customizer navigation area could scroll as normal and disappear out of view, while the editor top bar could lock into position directly underneath the Customizer top bar. This can help maximize space in the canvas area while keeping important actions visible.

In order to achieve this affect, I think we could try treating the editor top bar more like its own proper bar/section (right now it's more like a part of the canvas).

For added clarity, these are the different sections I'm referencing:

Arrows pointing to 4 areas: Customizer top bar, Customizer navigation, Editor top bar, and Canvas

Scrolled:

editor-top-bar.mov

Figma file is here :)

@critterverse critterverse added the [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. label Apr 16, 2021
@critterverse
Copy link
Contributor Author

Closing this issue for now as there are several ongoing conversations about adding functionality to the top area of this Customizer screen #30886 and #30720. No need to make this area more complicated while things are still being figured out!

@noisysocks
Copy link
Member

I saw that @talldan was working in this area so assigning him and moving to In Progress. Feel free to move it around if that's not right 🙂

@talldan
Copy link
Contributor

talldan commented May 18, 2021

I tried to implement the sticky aspect of the top bar as part of #31589, but it's complicated because the floating block toolbar anchors itself to the top of the scroll container when scrolling down. This implicit behavior caused it to sit underneath the top bar.

There were some potential solutions with trade offs:

  • use the fixed toolbar only in the customizer editor.
  • add an experimental offset prop to the BlockTools component.

But there might be better options, it needs more investigation.

@talldan talldan removed their assignment May 18, 2021
@critterverse
Copy link
Contributor Author

it's complicated because the floating block toolbar anchors itself to the top of the scroll container when scrolling down. This implicit behavior caused it to sit underneath the top bar.

I can see what you mean @talldan. Due to a similar issue, I think we should also the remove the reappear-on-reverse-scroll that is currently applied to the Customizer description container (where it says "Footer" with the back arrow):

customizer-toolbar-scroll.mov

^ Even when the fixed toolbar option is turned on, there are some issues with reshowing that container area on reverse scroll (it causes the fixed toolbar to lose stickiness and get knocked back into its default position at the top of the editor when scrolling from bottom to top). So either way, removing it seems like a step in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
4 participants