Have Post Editor’s notices obstruct the block toolbars #32488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +195 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
This was referenced Jun 7, 2021
|
@stokesman thanks for this, I just tested the draft in it's current state and from my perspective (as I reported in #32593) this fixes the regression. Additionally, based on what I see / understand from #32000 it looks good on that front too. Thank you! |
4 tasks
stokesman
added
[Package] Block editor
- Add props for sticky top of block toolbars and popovers - Add onResize prop to EditorNotices - Use height of notices as sticky top for block toolbars - Restore styles for sticky notices - Set z-index of notices to higher than block toolbars
stokesman
force-pushed
the
try/block-tools-sticky-top-prop
branch
from
296530e to
3a5d62d
Compare
|
This looks like a stale PR that hasn't seen any activity for some time. I'm closing for now but feel free to reopen and refresh if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a configurable sticky top position for the block toolbars it's possible to restore the sticky editor notices without regressing #32000. That was fixed by #32238 but may be considered breaking (at least one instance: #32593). Another minor point is this restores notices in the Post Editor to being more congruent with how they show up the Site Editor.
Implementation details that might want reconsidered
Instead of plumbing
__experimentalStickyTopthroughVisualEditorperhaps there should be a store action/selector added for it because I believe the value probably should factor into the calculation for scrolling a selection into view when navigating blocks with the keyboard.Changes summarized
How has this been tested?
Making notices in the Post Editor and checking that sticky positioning of block toolbars (floating and top) is as expected.
Screenshots
notices-obstruct-block-toolbar.mp4
Types of changes
bug fix: #32593
Checklist:
*.native.jsfiles for terms that need renaming or removal).