Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scroll behavior on the Customizer description container in Customizer Widgets screen #32060

Closed
critterverse opened this issue May 20, 2021 · 0 comments · Fixed by #32140
Closed

Remove scroll behavior on the Customizer description container in Customizer Widgets screen #32060

critterverse opened this issue May 20, 2021 · 0 comments · Fixed by #32140
Assignees
@talldan
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@critterverse
Copy link
Contributor

critterverse commented May 20, 2021 •
edited
Loading

Hi all, this bug has been spotted in a few different places like #31589 and #30912 (comment) but splitting it off until it's own issue so it doesn't get lost 😁

Resolving this should get us a step closer towards implementing a solution like the one proposed in #32061

customizer-toolbar-scroll.mov

I think we should remove the reappear-on-reverse-scroll that is currently applied to the Customizer description container. It's conflicting with the floating block toolbar, which anchors itself to the top of the scroll container while the selected block is passing in or out of view. It also causes issues with the fixed toolbar option, causing the fixed toolbar to lose stickiness and get knocked back into its default position at the top of the editor when scrolling from bottom to top.
This was referenced May 20, 2021
Closed
Closed
@critterverse critterverse added [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels May 20, 2021
@priethor priethor added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label May 21, 2021
@talldan talldan self-assigned this May 24, 2021
@talldan talldan mentioned this issue May 24, 2021
Merged
7 tasks
@talldan talldan added the [Status] In Progress Tracking issues with work in progress label May 24, 2021
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with customizer title overlapping block toolbar WordPress/gutenberg
4 participants
@youknowriad @talldan @priethor @critterverse