-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta boxes are hidden behind a scrollbar #19709
Comments
I feel like we go back and forth with this kind of issues. |
I recall doing a round of manual testing of meta boxes in the round of updates associated with #18732. From the screenshot, it seems to also have regressed #18873 (note the white gap above the meta border and below the beige canvas). But regarding the fact there is an initial scroll... it might be expected? At least, as part of the changes introduced with #16460, a |
A jargony term is that the toolbar is "below the fold". I personally think this is correct behavior. |
If you don't have "scrollbar always visible", you might not even notice that you have metaboxes, for me this is a bug that should be fixed. |
I have opinions on that option existing in the first place, but accept that it is the state of the world, and I do see your point. |
It's not clear to me what the fix would be. If the expectation with the typewriter implementation is that we always have a vertically-tall "gap" (which I think was used to intentionally force the scroll), then how can we expect a fix to not conflict with this? Some ideas:
cc @ellatrix |
I'm also not sure what a fix would look like. The space at the bottom is needed for the typewriter effect, but it doesn't need to be taken up by the click redirect element. The only requirement is that there is some space (50vh I believe). Perhaps we could try setting the height of the click redirect in JS rather than CSS. Personally I don't really mind the meta boxes showing under the fold (especially since it's legacy UI). Perhaps we can have a little label sticking out at the bottom to make it clear that they're there. |
If the challenge is purely that the metaboxes are invisible when below the fold with autohiding scrollbars, a classic fix is to simply ensure that they are just above the fold, so they indicate you can scroll. So the fix could be as "simple" as using <100% of the viewport height for the editing canvas. |
Hi @jasmussen, would you be able to propose a PR trying this fix? |
Done! |
* Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. * Try fixing the e2e test Co-authored-by: Riad Benguella <[email protected]>
* Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. * Try fixing the e2e test Co-authored-by: Riad Benguella <[email protected]>
* Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. * Try fixing the e2e test Co-authored-by: Riad Benguella <[email protected]>
Note that this does seem to work properly in WordPress 5.3
To reproduce
The text was updated successfully, but these errors were encountered: