Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Title and H1 font-size differ slightly #11223

Closed
spencerbaynton opened this issue Oct 29, 2018 · 2 comments · Fixed by #16253
Closed

Post Title and H1 font-size differ slightly #11223

spencerbaynton opened this issue Oct 29, 2018 · 2 comments · Fixed by #16253
Assignees
@jasmussen
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@spencerbaynton
Copy link

In pull request #5631 the typographic scale for headings was set to a major third scale with the values rounded to 2 decimal places. The post title's font-size was intended to "Match h1 heading." However, the post title font-size was not rounded. The post title's font-size should be 2.44em instead of 2.441em.
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 5, 2018
@ellatrix ellatrix added the Needs Design Feedback Needs general design feedback. label Jun 18, 2019
@ellatrix
Copy link
Member

Cc @jasmussen, as it's about your PR. :)

@jasmussen
Copy link
Contributor

Great ticket, I'll get this fixed. Have a bit on my table, but assigning myself, and will probably do next week.

@jasmussen jasmussen self-assigned this Jun 19, 2019
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. and removed Needs Design Feedback Needs general design feedback. Needs Testing Needs further testing to be confirmed. labels Jun 19, 2019
jasmussen pushed a commit that referenced this issue Jun 24, 2019
Fix h1 heading typo so h1 is same size as title
0890a72 
Fixes #11223. This is the smallest PR I've ever made. It's one character.

But it does fix a typo so the font size of the post title is the same as the h1.
@jasmussen jasmussen mentioned this issue Jun 24, 2019
Merged
jasmussen added a commit that referenced this issue Jun 24, 2019
@jasmussen
Fix h1 heading typo so h1 is same size as title (#16253)
4246e7d 
Fixes #11223. This is the smallest PR I've ever made. It's one character.

But it does fix a typo so the font size of the post title is the same as the h1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix h1 heading typo so h1 is same size as title WordPress/gutenberg
4 participants
@designsimply @jasmussen @spencerbaynton @ellatrix