0.7.0 #433
Merged
0.7.0 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-fixing-for-array-key-spacing-restrictions Make ArrayKeySpacingRestrictions errors fixable
This adds functions and closures to the control structure spacing sniff. The sniff checks for proper spacing on each side of each of the parentheses. It also checks that the opening brace is on the same line. I’ve actually improved the sniff while I was at it, to check for excess space in addition to insufficient space. Because of these improvements, and due to the non-configurability of the upstream version of this sniff, this sniff is really not a duplicate, and so #385 can be closed. Fixes #412, #385
Ignore twig files for scanning
Refer to the correct GitHub issue in the docs
Adds the `spaces_before_closure_open_paren` setting to the sniff. It determines how many spaces come between the `function` keyword in a closure and the opening parenthesis.
Check spacing of function declarations
They implicitly unslash the data passed to them, so it doesn't need to be put through `wp_unslash()` as well. Fixes #426
Add intval() and boolval() to unslashing functions
Add do_shortcode to list of autoescaped functions
`hash_equals()` returns a boolean value, and does not print anything directly, so it is safe to pass unsanitized data to it.
…equals Add hash_equals() to list of sanitizing functions
The `T_USE` token is also used to import traits to classes, and to import classes into namespaces. Fixes #431
Only check T_USE tokens associated with closures
Most ternary conditions handled by this sniff occur within a set of parentheses, and these are handled when an open parenthesis is encountered in the token loop. However, the echo “function” is often used without parentheses. Because of this, special handling is required for ternary conditions that are used in an echo statement without parentheses. Previously the code for detecting this scenario was unnecessarily complex, and incorrectly identified some ternary conditions as not occurring in parentheses when they actually did. The result of this was twofold: first, it would sometimes flag an expression as needing to be escaped when it did not; and second, it could also skip over an expression that did need to be escaped without flagging it. This is now fixed. Fixes #421
Simplify and improve ternary handling in XSS sniff
Change log for 0.7.0
JDGrimes
added a commit
that referenced
this pull request
Aug 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for tracking changes to be released in 0.7.0.