Check spacing of function declarations #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds functions and closures to the control structure spacing sniff. The sniff checks for proper spacing on each side of each of the parentheses. It also checks that the opening brace is on the same line. I’ve actually improved the sniff while I was at it, to check for excess space in addition to insufficient space. Because of these improvements, and due to the non-configurability of the upstream version of this sniff, this sniff is really not a duplicate, and so #385 can be closed. Fixes #412, #385
| } | ||
| } | ||
|
|
||
| if ( |
There was a problem hiding this comment.
This block seems to be indented one level too many?
Adds the `spaces_before_closure_open_paren` setting to the sniff. It determines how many spaces come between the `function` keyword in a closure and the opening parenthesis.
|
I've updated this:
|
GaryJones
added a commit
that referenced
this pull request
Aug 25, 2015
Check spacing of function declarations
|
Excellent work, thanks @JDGrimes! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions and closures to the control structure spacing
sniff. The sniff checks for proper spacing on each side of each of the
parentheses. It also checks that the opening brace is on the same line.
I’ve actually improved the sniff while I was at it, to check for excess
space in addition to insufficient space.
Because of these improvements, and due to the non-configurability of
the upstream version of this sniff, this sniff is really not a
duplicate, and so #385 can be closed.
I’ve also removed our implementation of the
FunctionDeclarationArgumentSpacingsniff in favor of the upstream version. This is some overlap between that sniff and this one, but that one only checks the spacing of the arguments.Fixes #412, #385