WPCS 2.0.0: Remove the deprecated VIP ruleset and sniffs #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VIP ruleset and sniffs were deprecated in WPCS 1.0.0 and will now be removed for WPCS 2.0.0.
jrfnl
force-pushed
the
feature/remove-deprecated-VIP-ruleset-sniffs
branch
from
cd09c18
to
239ce3f
Compare
GaryJones
reviewed
Dec 18, 2018
| @@ -111,6 +111,6 @@ $bad = array( 'key1' => 'value1', 'key2' => 'value2' ); // Bad. | |||
| // @codingStandardsChangeSetting WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_associative_arrays true | |||
|
|
|||
| $foo = array( | |||
| 'meta_key' => 'foo', // phpcs:ignore WordPress.VIP.SlowDBQuery.slow_db_query_meta_key | |||
| 'meta_value' => 'bar', // phpcs:ignore WordPress.VIP.SlowDBQuery.slow_db_query_meta_value | |||
| 'meta_key' => 'foo', // phpcs:ignore Standard.Category.SniffName.ErrorCode | |||
There was a problem hiding this comment.
What's the deal with these placeholders?
There was a problem hiding this comment.
These are tests just to see whether the sniff handles the PHPCS ignore annotations correctly, they should never have referenced real sniffs.
As they did and the sniff they refer to is now being removed, it seemed right to clean up the test.
GaryJones
approved these changes
Dec 18, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VIP ruleset and sniffs were deprecated in WPCS 1.0.0 and will now be removed for WPCS 2.0.0.