Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPCS 2.0: Migrate Deprecated VIP Sniffs #187

Closed
tomjn opened this issue Jul 25, 2018 · 3 comments · Fixed by #323
Closed

WPCS 2.0: Migrate Deprecated VIP Sniffs #187

tomjn opened this issue Jul 25, 2018 · 3 comments · Fixed by #323

Comments

@tomjn
Copy link
Contributor

tomjn commented Jul 25, 2018

WPCS 1.0.0 deprecates VIP sniffs, with the intention that they be removed in a later release. We should copy these sniffs to VIP Minimum appropriatley so that our own sniffs and rules aren't broken by a future release

@GaryJones
Copy link
Contributor

GaryJones commented Aug 8, 2018

All but one of the WordPressVIPMinimum/Sniffs implement a core PHPCS sniff (PHP_CodeSniffer_Sniff currently, but will be PHP_CodeSniffer\Sniffs\Sniff if #190 happens first). There is no dependency on WPCS here.

The other Sniff, DeclarationCompatibilitySniff, extends \PHP_CodeSniffer_Standards_AbstractScopeSniff. There is no dependency on WPCS here.


Our ruleset.xml files contain references to WordPress.VIP, which need to be removed. See #298.

@GaryJones
Copy link
Contributor

All but one of the WordPressVIPMinimum/Sniffs implement a core PHPCS sniff

Correction - there are three classes in WordPressVIPMinimum/Sniffs/VIP that extend WPCS classes directly.

@GaryJones
Copy link
Contributor

GaryJones commented Dec 18, 2018

WPCS has just removed the VIP sniffs from it's develop branch, with the aim to push this out as a WPCS 2.0.0 soon.

As such, we should finish off the migration of the WordPress.VIP sniffs, and check our dependency constraints (constraint is "1.*", so we're fine here).

@GaryJones GaryJones added this to the 0.5.0 milestone Dec 18, 2018
@GaryJones GaryJones changed the title Migrate Deprecated VIP Sniffs WPCS 2.0: Migrate Deprecated VIP Sniffs Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants