Requests: set default options as a constant #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values do not change during the request, so should be a constant and as the minimum PHP version is now PHP 5.6, we can use constant scalar expressions and constant arrays in constants.
schlessera
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values do not change during the request, so should be a constant and as the minimum PHP version is now PHP 5.6, we can use constant scalar expressions and constant arrays in constants.
Note: as this class is not final, I'm using
staticfor the option defaults, but for security purposes, usingselffor the call toget_certificate_path().👉🏻 Should the
Requests::get_certificate_path()method be madefinal?Part of a PR series to address #513