Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check through code base for use of "magic numbers" #513

Closed
3 tasks done
jrfnl opened this issue Aug 20, 2021 · 3 comments
Closed
3 tasks done

Check through code base for use of "magic numbers" #513

jrfnl opened this issue Aug 20, 2021 · 3 comments
Assignees
@jrfnl
Labels
Type: testing/chores/QA
Milestone
2.0.0

Comments

@jrfnl
Copy link
Member

jrfnl commented Aug 20, 2021 •
edited
Loading

Most notably in the cURL transport class, hard-coded numbers are used for various cURL error codes.

Task:

  • Go through the code base to find these numbers
  • Check if there is a PHP constant which can be used instead and if that constant is available in all supported PHP versions and if so, switch over
  • For "magic numbers" which don't have a PHP native constant, create a descriptive class constant instead and use that.
@jrfnl jrfnl added this to the 2.0.0 milestone Aug 20, 2021
@jrfnl jrfnl self-assigned this Aug 20, 2021
@jrfnl
Copy link
Member Author

jrfnl commented Aug 20, 2021

Relevant links:

@jrfnl
Copy link
Member Author

jrfnl commented Aug 30, 2021

PR ready. Will pull after #519 has been merged to prevent merge-conflict hell.

This was referenced Sep 17, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@jrfnl
Copy link
Member Author

jrfnl commented Sep 17, 2021

All related PRs have been merged. Closing the issue.

@jrfnl jrfnl closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrfnl jrfnl

Labels
Type: testing/chores/QA
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@jrfnl