Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:test: don't assume /dev/shm exists #172

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix:test: don't assume /dev/shm exists #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
377d371
fix:test: don't assume /dev/shm exists
melsabagh Jun 28, 2022
c0d9151
fix(tests): default /tmp omitted by mistake
melsabagh Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion runtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#!/bin/bash

TMPDIR=/dev/shm
TMPDIR=/tmp
SHM_DIR=/dev/shm
if [[ -d "${SHM_DIR}" ]]
then
TMPDIR="${SHM_DIR}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about still getting a TMPDIR in all cases on /tmp/?
Things may fail otherwise? This is needed in

pyahocorasick/runtest.sh

Line 72 in 377d371

MEMORY_DEBUG_PATH="${TMPDIR}/memory.dump"
and a few other places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I omitted the default by mistake. Addressed in c0d9151.

fi

if [[ ${PYTHON} == "" ]]
then
Expand Down