Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:test: don't assume /dev/shm exists #172

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

melsabagh
Copy link
Contributor

No description provided.

SHM_DIR=/dev/shm
if [[ -d "${SHM_DIR}" ]]
then
TMPDIR="${SHM_DIR}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about still getting a TMPDIR in all cases on /tmp/?
Things may fail otherwise? This is needed in

MEMORY_DEBUG_PATH="${TMPDIR}/memory.dump"
and a few other places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I omitted the default by mistake. Addressed in c0d9151.

Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
merging

@pombredanne pombredanne merged commit 8b85045 into WojciechMula:master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants