Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prebuild dependency to v11.0.4 #845

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented Jul 15, 2022

This PR ensures (even though all semver patches are already accepted for prebuild) that Electron headers are properly pulled in the build process for newer Electron versions, since prebuild/prebuild#292 is now merged and included in v11.0.4.

This PR will also allow #834 to be merged.

@m4heshd m4heshd requested review from JoshuaWise and a team as code owners July 15, 2022 19:09
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants