Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete contact by prefix #264

Merged
merged 2 commits into from
May 30, 2024

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented May 22, 2024

The endpoint on KERIA doesn't return a JSON response, so deleting via contact is throwing an error:

SyntaxError: Unexpected end of JSON input
  at JSON.parse (<anonymous>)

I can add integration tests to cover contacts if we think it's worthwhile but I'd need to find time.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (6113497) to head (eb6f089).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   83.51%   83.51%   -0.01%     
==========================================
  Files          46       46              
  Lines        4210     4209       -1     
  Branches     1047     1047              
==========================================
- Hits         3516     3515       -1     
+ Misses        690      666      -24     
- Partials        4       28      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan self-requested a review May 30, 2024 13:54
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenkan lenkan merged commit 3e96c1e into WebOfTrust:main May 30, 2024
8 checks passed
@iFergal iFergal deleted the fix/deleteContact branch May 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants