Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): delete connection from KERIA before DB (better reliability) #571

Merged

Conversation

Sotatek-BaoHoanga
Copy link
Collaborator

@Sotatek-BaoHoanga Sotatek-BaoHoanga commented Jul 11, 2024

Description

Review delete local vs delete on KERIA ordering

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [https://cardanofoundation.atlassian.net/browse/DTIS-861]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-3pq4yhgyg.vercel.app

@Sotatek-BaoHoanga Sotatek-BaoHoanga marked this pull request as ready for review July 11, 2024 06:44
@Sotatek-BaoHoanga Sotatek-BaoHoanga self-assigned this Jul 11, 2024
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-p36c3c3k1.vercel.app

@iFergal iFergal changed the title feat(core): Review delete local vs delete on keria ordering feat(core): delete connection from KERIA before DB (better reliability) Jul 11, 2024
@iFergal iFergal merged commit 3445959 into develop Jul 11, 2024
1 check passed
@iFergal iFergal deleted the feat/DTIS-861-review-delete-local-vs-delete-on-KERIA-ordering branch July 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants