Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving these scripts to new repo at WebOfTrust/signify-integration #173

Merged

Conversation

pfeairheller
Copy link
Member

This PR removes the examples/scripts directory moving all of these scripts to a new repo. This closes #164

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a015c2) 81.36% compared to head (a3395cb) 81.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #173   +/-   ##
============================================
  Coverage        81.36%   81.36%           
============================================
  Files               46       46           
  Lines             4149     4149           
  Branches          1030     1030           
============================================
  Hits              3376     3376           
  Misses             741      741           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just need to run npm install in the root to update the lock file. It looks like some react dependencies from the react example was added.

package-lock.json Outdated Show resolved Hide resolved
@pfeairheller
Copy link
Member Author

I think you just need to run npm install in the root to update the lock file. It looks like some react dependencies from the react example was added.

Ok, I did that once but now I've done it again.

@lenkan
Copy link
Collaborator

lenkan commented Dec 7, 2023

I think you just need to run npm install in the root to update the lock file. It looks like some react dependencies from the react example was added.

Ok, I did that once but now I've done it again.

Strange. Only thing I can think of is that the first time you ran it you still had the package.json from the react code present somehow. Maybe before a rebase? The entries are gone now anyway.

@pfeairheller pfeairheller merged commit cfb001b into WebOfTrust:development Dec 7, 2023
5 checks passed
@pfeairheller pfeairheller deleted the feat-remove-scripts branch December 7, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide what to do with the remaining scripts in /scripts directory
2 participants