Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with the remaining scripts in /scripts directory #164

Closed
lenkan opened this issue Dec 6, 2023 · 3 comments · Fixed by #173
Closed

Decide what to do with the remaining scripts in /scripts directory #164

lenkan opened this issue Dec 6, 2023 · 3 comments · Fixed by #173
Assignees

Comments

@lenkan
Copy link
Collaborator

lenkan commented Dec 6, 2023

Since #161, all scripts in /integration-scripts are converted to run as integration tests. In the /scripts directory, we have these files. It is a mix of .ts, .py and shell scripts. Some to be used together. Currently they are not being exercised in any workflow, so hard to tell if all of them still work.

Do we want to keep some of them? If so, which?

@pfeairheller
Copy link
Member

The point of these scripts was to exercise cross client functionality. So multisig with kli, SigPy and SigTS. I think they are very important scripts but probably belong in a repo of their own.

@pfeairheller
Copy link
Member

I propose creating a signify-integration repo and moving these scripts there. That will make setting up all the dependencies easier and clean up this repo.

@pfeairheller pfeairheller self-assigned this Dec 7, 2023
@kentbull
Copy link
Contributor

kentbull commented Dec 7, 2023

I suggest referencing the signify-integration repo from the signify-ts repo so people know signify-integration exists and can factor it into their CI/CI pipeplines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants