Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codecov #53

Merged
merged 1 commit into from
Jan 31, 2023
Merged

codecov #53

merged 1 commit into from
Jan 31, 2023

Conversation

jasoncolburne
Copy link
Collaborator

@jasoncolburne jasoncolburne commented Jan 31, 2023 •
edited
Loading

Changes

  • require 95% coverage
  • only check src (useful if we add build.rs)

Screenshots

Screenshot 2023-01-31 at 9 08 39 AM

@jasoncolburne jasoncolburne linked an issue Jan 31, 2023 that may be closed by this pull request
Re-configure Codecov #39
Closed
@jasoncolburne jasoncolburne changed the title Add Codecov rules Add Codecov Rules Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Merging #53 (ab7d387) into main (7794e2f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files           6        6           
  Lines         751      751           
=======================================
  Hits          658      658           
  Misses         93       93

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasoncolburne
Copy link
Collaborator Author

Hmm I expected that check to fail

@jasoncolburne jasoncolburne changed the title Add Codecov Rules codecov Jan 31, 2023
@jasoncolburne
Copy link
Collaborator Author

jasoncolburne commented Jan 31, 2023 •
edited
Loading

This should ship after or immediately before #48, which increases coverage.

@jasoncolburne jasoncolburne marked this pull request as ready for review January 31, 2023 13:12
@jasoncolburne jasoncolburne requested a review from m00sey as a code owner January 31, 2023 13:12
@jasoncolburne jasoncolburne merged commit 191d5b8 into WebOfTrust:main Jan 31, 2023
@jasoncolburne jasoncolburne deleted the codecov branch January 31, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00sey m00sey m00sey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-configure Codecov
2 participants
@jasoncolburne @m00sey