Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-configure Codecov #39

Closed
jasoncolburne opened this issue Jan 26, 2023 · 4 comments · Fixed by #53
Closed

Re-configure Codecov #39

jasoncolburne opened this issue Jan 26, 2023 · 4 comments · Fixed by #53

Comments

@jasoncolburne
Copy link
Collaborator

Codecov started running checks in a recent PR, we're unsure why. Investigate and determine the appropriate settings moving forward.

In particular, the diff action/job seems to be failing, leading to a failed CI run.
@m00sey m00sey added the bug Something isn't working label Jan 27, 2023
@m00sey
Copy link
Member

m00sey commented Jan 27, 2023

I had a notification to "approve" updated codecov settings. I'm wondering if that makes any difference moving forward.

@m00sey m00sey removed the bug Something isn't working label Jan 27, 2023
@jasoncolburne
Copy link
Collaborator Author

I fixed this in the pending Counter PR.

@jasoncolburne jasoncolburne linked a pull request Jan 29, 2023 that will close this issue
counter #48
Merged
@jasoncolburne
Copy link
Collaborator Author

I'm removing this from the PR, the change was easy enough to make and the PR isn't red because of it. Moving forward we can decide which checks we want to show up, since if we push the coverage super high it will mean that some PRs won't be able to match coverage.

@jasoncolburne jasoncolburne removed a link to a pull request Jan 31, 2023
counter #48
Merged
@jasoncolburne
Copy link
Collaborator Author

I have thought about this. After increasing coverage to 98%, it's going to be hard to ensure PRs match previous coverage. We are likely better off setting a threshold in codecov.yml of 95-97%.

@jasoncolburne jasoncolburne linked a pull request Jan 31, 2023 that will close this issue
codecov #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codecov jasoncolburne/cesride
2 participants
@m00sey @jasoncolburne