-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update package dependencies #16
update package dependencies #16
Conversation
The only dependencies we have now are the two maintained/audited @noble packages and the libsodium package. |
If you are removing the urlsafe-base64 in favor of Node native calls are you pinning this library to be Node only? Meaning will it no longer be available for Browsers? |
That was my question as well. Will the |
One thing I noticed is that in signify we do the following
Currently trying to refactor signify to use cesr-ts but It will probably take me the weekend! |
Yes, @AlexAndrei98 , and the Node.js docs explicitly suggest |
Looks like the import statement @AlexAndrei98 quotes above references the |
OK. Using the |
fixes #7 |
Eliminates sketchy packages:
text-encoding
(remove)urlsafe-base64
(remove in favor of native node.js capability)ecdsa-secp256r1
(replace with@noble/curves
)fixes
text-encoding
npm package no longer maintained? Do we care? #6fixes Suggest moving off of ecdsa-secp256r1 npm package in favor of @noble/curves #12
fixes
urlsafe-base64
package vs. built-in node.js Buffer.from() and buf.toString() with 'base64url' flag? #13