Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete blake3 and replace with @noble/hashes #15

Closed

Conversation

AlexAndrei98
Copy link

@AlexAndrei98 AlexAndrei98 commented Dec 5, 2023

fixes #7

@kentbull
Copy link

kentbull commented Dec 5, 2023

This would be really cool. I'm hoping this eventually means we don't have to call the dynamic Blake3 import in Signify as is done here:

        const b3 = await import('blake3/browser-async');
        await b3.default(
            'https://cdn.jsdelivr.net/npm/[email protected]/dist/wasm/web/blake3_js_bg.wasm'
        );
        await _sodium.ready;

Looks like we still need to await _sodium.ready though. I haven't heard of a Libsodium implementation in pure JS that works for us.

@jrayback
Copy link
Collaborator

jrayback commented Dec 7, 2023

@AlexAndrei98 , the changes in the PR are replicated in #16, which more broadly addresses the dependency issue . It would be cleanest to close this PR out and just merge the other.

@AlexAndrei98
Copy link
Author

closing this in favor of #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest moving away from npm blake3 package
3 participants