Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for legacy stringref text syntax #6289

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

tlively
Copy link
Member

@tlively tlively commented Feb 8, 2024

Removing support for the legacy syntax will allow us to avoid implementing
support for it in the new text parser.

Removing support for the legacy syntax will allow us to avoid implementing
support for it in the new text parser.
@tlively tlively requested a review from kripken February 8, 2024 20:01
@tlively
Copy link
Member Author

tlively commented Feb 8, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@kripken
Copy link
Member

kripken commented Feb 8, 2024

How are you defining "legacy stringref text syntax"?

@tlively
Copy link
Member Author

tlively commented Feb 8, 2024

Just the stuff marked with // Legacy syntax comments in the old parser. All the deleted forms take separate behavior modifiers as immediates and have new replacements that use single mnemonics that are more consistent with the rest of the language and already supported by the new parser.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks.

@tlively
Copy link
Member Author

tlively commented Feb 8, 2024

Merge activity

  • Feb 8, 5:59 PM EST: @tlively started a stack merge that includes this pull request via Graphite.
  • Feb 8, 6:00 PM EST: @tlively merged this pull request with Graphite.

@tlively tlively merged commit e7b3470 into main Feb 8, 2024
15 checks passed
@tlively tlively deleted the remove-legacy-string-syntax branch February 8, 2024 23:00
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Removing support for the legacy syntax will allow us to avoid implementing
support for it in the new text parser.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants