Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parser] Issues to resolve before switching to the new wat parser #6208

Closed
17 of 18 tasks
tlively opened this issue Jan 6, 2024 · 2 comments
Closed
17 of 18 tasks

[Parser] Issues to resolve before switching to the new wat parser #6208

tlively opened this issue Jan 6, 2024 · 2 comments

Comments

@tlively
Copy link
Member

tlively commented Jan 6, 2024

These are the issues (in no particular order) that need to be resolved before we can turn on the new wat parser by default:

@kripken
Copy link
Member

kripken commented Jan 11, 2024

Perhaps also worth adding #3989 as it blocks us from running the text roundtripping fuzzer, and it would be good to have that fuzzer tested on the new parser:

binaryen/scripts/fuzz_opt.py

Lines 1386 to 1387 in e5948a9

# FIXME: Re-enable after https://github.com/WebAssembly/binaryen/issues/3989
# RoundtripText()

@tlively
Copy link
Member Author

tlively commented May 20, 2024

The new parser is now on by default, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants