Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation script for A/B system-as-root devices #14

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Fix installation script for A/B system-as-root devices #14

merged 2 commits into from
Dec 22, 2019

Conversation

dllud
Copy link
Contributor

@dllud dllud commented Dec 22, 2019

A/B system-as-root devices have the actual system partition mounted under /system/system when in the recovery.

This should fix both #11 and #12. Though, before closing those issues, we need input from @oscaropenness and @Br31zh to know if they are using A/B system-as-root devices.

Taken from
https://gitlab.com/fdroid/privileged-extension/commit/decd7f35ef64e8ec696d2a9feae38fd802479705

A/B system-as-root devices have the actual system partition
mounted under /system/system when in the recovery.
Taken from
https://gitlab.com/fdroid/privileged-extension/commit/decd7f35ef64e8ec696d2a9feae38fd802479705
Copy link
Member

@Roboe Roboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You did a great job. Also thank you for properly documenting each commit, :)

@Roboe Roboe merged commit 3260f77 into WeAreFairphone:master Dec 22, 2019
@dllud
Copy link
Contributor Author

dllud commented Dec 22, 2019

My pleasure. Please consider issuing a new release once the affected people at #11 and #12 reply. Or release either way in a couple of weeks in case there's no reply there.

@Roboe
Copy link
Member

Roboe commented Jan 15, 2020

(For future reference: I did it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants