Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it working on LineageOS 16 (Android 9 Pie) ? #12

Closed
Br31zh opened this issue Dec 16, 2019 · 9 comments
Closed

Is it working on LineageOS 16 (Android 9 Pie) ? #12

Br31zh opened this issue Dec 16, 2019 · 9 comments
Labels
help wanted

Comments

@Br31zh
Copy link

Br31zh commented Dec 16, 2019

Hello, I'm using LineageOS 16, and since it's working with LOS15 but not LOS17, do you know if it works on LOS16 ?

Thanks.
@dllud
Copy link
Contributor

dllud commented Dec 21, 2019

I can confirm that unifiednlp-minimal_2018-08-17.zip does not work on LineageOS 16. I am trying to install it with TWRP. The installation seems to be successful but no files get into /system/priv-app neither /etc/permissions.

Placing the files there manually (via adb push) does work and, after reboot, makes the UnifiedNlp Settings appear in the Location Settings.

Perhaps update-binary needs a fix to correctly work on Android 9?

@dllud dllud mentioned this issue Dec 22, 2019
Merged
@dllud
Copy link
Contributor

dllud commented Dec 22, 2019

@Br31zh Does your device use an A/B system-as-root partition style? If so #14 should fix this for you, perhaps in conjugation with #13.

Roboe pushed a commit that referenced this issue Dec 22, 2019
@dllud @Roboe
[issues #11 #12] Fix installation script for A/B system-as-root devices
b0b5d73 
A/B system-as-root devices have the actual system partition
mounted under /system/system when in the recovery.
Taken from
https://gitlab.com/fdroid/privileged-extension/commit/decd7f35ef64e8ec696d2a9feae38fd802479705
@Roboe
Copy link
Member

Roboe commented Dec 23, 2019

I've prepared a pre-release with @dllud contributions. Could someone test them and report results, please? 🙏

https://github.com/WeAreFairphone/flashable-zip_microG/tree/2019-12-23

Thanks everyone!

@snm247
Copy link

snm247 commented Dec 29, 2019

The pre-release works on LineageOS 16. After installation and booting into system UnifiedNLP is available in System Settings.

@Br31zh
Copy link
Author

Br31zh commented Jan 14, 2020 •
edited
Loading

Sorry for the delay, but I confirm that the 2019-12-23 pre-release is working (at least with unifiednlp-minimal) on LineageOS 16. Thanks!

@Roboe
Copy link
Member

Roboe commented Jan 15, 2020

Great! Thank you all for testing. I'll make a release right now.

@Roboe Roboe closed this as completed Jan 15, 2020
@Roboe Roboe reopened this Jan 15, 2020
@Roboe
Copy link
Member

Roboe commented Jan 15, 2020 •
edited
Loading

Ok, I released it: 2020-01-15. There's just a little thing to improve the description there and finally close this issue.

Could someone tell me if the "Note for UnifiedNLP on Android Oreo" in 2018-08-17 is still valid for Pie? I.e. if an icon for UnifiedNlp appears in the app drawer or the user should access its config from Location Settings.

@dllud
Copy link
Contributor

dllud commented Jan 15, 2020

Thanks for the effort @Roboe .

The interface on Pie is the same as in Oreo: user must access it from the Location Settings.

@Roboe
Copy link
Member

Roboe commented Jan 15, 2020

Ok, I'll add that to the release description. Thank you again!

@Roboe Roboe closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dllud @snm247 @Roboe @Br31zh