-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHA256 digest to cached file name #61
Conversation
src/main/java/me/srrapero720/watermedia/api/cache/CacheAPI.java
Outdated
Show resolved
Hide resolved
you can PR the same patch for |
6b32dc7
to
a999f37
Compare
Should I better import the org.apache.commons.codec.binary.Hex class in the top of leave it like this? |
for this branch if can be removed Hex usage can be aproved on |
honestly, if can be copied the method into a |
Oh I didn't knew that Minecraft must have the dependency too. I'm brand new to Minecraft modding so I don't know the shenanigans... |
Oh yes we can copy the function alone if this is allowed |
Fixes caching failure when URL is too long (e.g. discord hosted ones). Fixes illegal characters on Windows (namely '\') that can show up in base64.
I replaced the dependency to |
Fixes caching failure when URL is too long (e.g. discord hosted ones). Fixes illegal characters on Windows (namely '\') that can show up in base64.
Replaces base64 encoding by SHA256 digest to generate cached files names.
Fixes caching failure when URL is too long (e.g. discord hosted ones).
Fixes illegal characters on Windows (namely '\') that can show up in base64.
I also did a patch for the last release (2.0.31) : https://github.com/zFERDQFREZrzfq/watermedia/tree/patch-cache-2.0.31