Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CacheAPI] Overhaul CacheCore and build it in a API #33

Open
SrRapero720 opened this issue Nov 3, 2023 · 4 comments
Open

[CacheAPI] Overhaul CacheCore and build it in a API #33

SrRapero720 opened this issue Nov 3, 2023 · 4 comments
Labels
Type: Enhancement New feature or request
Milestone

Comments

@SrRapero720
Copy link
Member

Rework of the internal CacheCore and make it accessible in a API
Should works hand-to-hand with the ImageAPI and PlayerAPI for local catching multimedia (like videos)

Speeding media loading times and reduce bandwidth usage.

@SrRapero720 SrRapero720 converted this from a draft issue Nov 3, 2023
@SrRapero720 SrRapero720 changed the title CacheAPI [CacheAPI] Overhaul CacheCore and build it in a API Nov 3, 2023
@SrRapero720 SrRapero720 added this to the WATERMeDIA 2.1.0 milestone Nov 3, 2023
@SrRapero720 SrRapero720 added the Type: Enhancement New feature or request label Jan 2, 2024
@SrRapero720 SrRapero720 moved this from Todo to In Progress in WATERMeDIA 3.0 - rewrite Mar 21, 2024
@SrRapero720
Copy link
Member Author

TODO related to #61
We should also modify fallback code to ensure (even if digest fails) not have long filenames or duplicated filenames (which occurred sometimes using Base64

@zFERDQFREZrzfq
Copy link
Contributor

zFERDQFREZrzfq commented Apr 19, 2024

As far as I know, the fallback is actually never used since the digest can only fail if the SHA-256 is actually removed from the Java's MessageDigest.
I left it to have a return outside of the try, but I don't know if it's the best way to do.

@SrRapero720
Copy link
Member Author

is a "just in case" fallback. modding is super weird. native threads have problems with forge's event bus... making context classloader always null (instead of fallback on system classloader) so i expect everything at this point

@SrRapero720 SrRapero720 moved this from In Progress to Todo in WATERMeDIA 3.0 - rewrite Apr 21, 2024
@SrRapero720
Copy link
Member Author

this needs more observation. Is planned merge it on MRL class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants