Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the JSON authoring view #1207

Merged
merged 8 commits into from
May 24, 2018
Merged

Improved the JSON authoring view #1207

merged 8 commits into from
May 24, 2018

Commits on May 21, 2018

  1. Authoring Tool: Added a "Valid JSON" and "Invalid JSON" message when … 

    …authoring the project JSON.
    @geoffreykwan
    geoffreykwan committed May 21, 2018
    Configuration menu
    Copy the full SHA
    a09bd47 View commit details
    Browse the repository at this point in the history

  2. Authoring Tool: Renamed the showValidJSONMessage() function to showJS… 

    …ONValidMessage() to be more consistent with the other code.
    @geoffreykwan
    geoffreykwan committed May 21, 2018
    Configuration menu
    Copy the full SHA
    d8b9f0e View commit details
    Browse the repository at this point in the history

  3. Authoring Tool: Moved the showJSONValidMessage() functions to the Uti… 

    …lService.
    @geoffreykwan
    geoffreykwan committed May 21, 2018
    Configuration menu
    Copy the full SHA
    15b599e View commit details
    Browse the repository at this point in the history

  4. Authoring Tool: Updated the autoSaveProjectJSONString() function to n… 

    …ot return anything because we never use the return value.
    @geoffreykwan
    geoffreykwan committed May 21, 2018
    Configuration menu
    Copy the full SHA
    613ddae View commit details
    Browse the repository at this point in the history

  5. Made the step JSON authoring view display the "JSON Valid" or "JSON I… 

    …nvalid" message when editing the JSON.
    @geoffreykwan
    geoffreykwan committed May 21, 2018
    Configuration menu
    Copy the full SHA
    d4329b8 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. Discussion: Updated the JSON authoring view to be more user friendly … 

    …by displaying the "JSON Valid" or "JSON Invalid" message. We also display a confirm popup when the JSON is invalid and the author tries to close the JSON authoring view.
    @geoffreykwan
    geoffreykwan committed May 22, 2018
    Configuration menu
    Copy the full SHA
    1b4f63b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Added a check mark for valid and x for invalid. Also increased the fo… 

    …nt size a little bit.
    @geoffreykwan
    geoffreykwan committed May 24, 2018
    Configuration menu
    Copy the full SHA
    b9b44b0 View commit details
    Browse the repository at this point in the history

  2. AT: Hide JSON textbox for advanced activity authoring if the JSON is … 

    …valid.
    @hirokiterashima
    hirokiterashima committed May 24, 2018
    Configuration menu
    Copy the full SHA
    af0d915 View commit details
    Browse the repository at this point in the history