Improved the JSON authoring view #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…authoring the project JSON.
…ONValidMessage() to be more consistent with the other code.
…ot return anything because we never use the return value.
…nvalid" message when editing the JSON.
…by displaying the "JSON Valid" or "JSON Invalid" message. We also display a confirm popup when the JSON is invalid and the author tries to close the JSON authoring view.
hirokiterashima
requested changes
May 23, 2018
hirokiterashima
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all the different JSON authoring views, make sure the "JSON Valid" and "JSON Invalid" message displays properly when the JSON is changed. Also make sure the message goes away when the author leaves the view. If the JSON is invalid and the author tries to close the JSON authoring view, it should display a confirm popup asking if they want to revert to the last valid JSON or keep the invalid JSON open to try to fix it.
Check these views